#1624: Incorrect check for FreeBSD in cryptodev engine

| Logout
Logged in as guest

RT for openssl.org

X Ticket metadata

X The Basics

Id:	1624
Status:	resolved
Left:	0 min
Priority:	0/0
Queue:	OpenSSL-Bugs

X Custom Fields

Milestone:	(no value)
Subsystem:	(no value)
Severity:	(no value)
Broken in:	(no value)

X People

Owner:	steve <steve@openssl.org>
Requestors:	simon@FreeBSD.org
Cc:
AdminCc:

X Dates

Created:	Mon Dec 17 12:17:46 2007
Starts:	Not set
Started:	Sun Jul 12 00:31:24 2009
Last Contact:	Not set
Due:	Not set
Closed:	Sun Jul 12 00:31:24 2009
Updated:	Sun Jul 12 00:31:25 2009 by steve

X Links

Depends on:
Depended on by:
Parents:
Children:
Refers to:
Referred to by:

X Attachments
openssl-vendor-cryptodev-freebsd-check.patch Mon Dec 17 12:17:47 2007 (715b) by simon@FreeBSD.org

X More about Simon L. Nielsen

Comments about this user:
No comment entered about this user
This user's 10 highest priority tickets:

Groups this user belongs to:

Everyone
Unprivileged

X History

Display mode:[Brief headers] [Full headers]

Mon Dec 17 12:17:47 2007

simon@FreeBSD.org - Ticket created

Subject:	Incorrect check for FreeBSD in cryptodev engine
Date:	Sun, 16 Dec 2007 11:23:32 +0100
To:	rt@openssl.org
From:	"Simon L. Nielsen" <simon@FreeBSD.org>

Download (untitled)

text/plain 488b

Hey,

The check in crypto/engine/eng_cryptodev.c for FreeBSD is incorrect
and never enables the code on FreeBSD as __FreeBSD_version is only set
if param.h is included, which it isn't yet at that point.

The attached patch by Norikatsu Shigemura <nork@FreeBSD.org> fixes the
problem.

The patch can also be found at the following URL in case the
attachment is mangled in transit:
http://people.freebsd.org/~simon/patches/openssl-vendor-cryptodev-freebsd-check.patch

--
Simon L. Nielsen

Download openssl-vendor-cryptodev-freebsd-check.patch

text/x-diff 715b

Sun Jul 12 00:30:58 2009

steve - Taken

Sun Jul 12 00:31:24 2009

steve - Status changed from 'new' to 'resolved'

Time to display: 0.470192