Skip Menu | | Logout
Logged in as guest
RT for openssl.org
 
 
#1872: [PATCH] Change 'Q' and 'R' behavior in s_client
X  Ticket metadata  
X  The Basics  
Id: 1872
Status: new
Left: 0 min
Priority: 0/0
Queue: OpenSSL-Bugs

X  Custom Fields  
Milestone:
  • (no value)
Subsystem:
  • (no value)
Severity:
  • (no value)
Broken in:
  • (no value)

X  People  
Owner: Nobody
Requestors: openssl@benizi.com
Cc:
AdminCc:

X  Dates  
Created: Fri Mar 20 11:49:44 2009
Starts: Not set
Started: Not set
Last Contact: Not set
Due: Not set
Closed: Not set
Updated: Fri Mar 20 11:49:46 2009 by openssl@benizi.com

X  Links  
Depends on:
Depended on by:
Parents:
Children:
Refers to:
Referred to by:

X  Attachments  
openssl-commandkeys.patch
openssl-removeqr.patch

X  More about Benjamin R. Haskell  
Comments about this user:
No comment entered about this user
This user's 10 highest priority tickets:
Groups this user belongs to:
  • Everyone
  • Unprivileged

X  History Display mode:[Brief headers] [Full headers]
#     Fri Mar 20 11:49:44 2009  openssl@benizi.com - Ticket created    
Subject: [PATCH] Change 'Q' and 'R' behavior in s_client
Date: Fri, 20 Mar 2009 06:39:43 -0400 (EDT)
To: OpenSSL RT <rt@openssl.org>
From: "Benjamin R. Haskell" <openssl@benizi.com>
Download (untitled)
text/plain 1.3k
The attached patches alter the way 'openssl s_client' surprisingly
interprets the 'Q' and 'R' characters at the start of a line.

Option 1: openssl-removeqr.patch : eliminates the 'Q' and 'R' "commands"
completely, from s_client and the documentation.

Option 2: openssl-commandkeys.patch : adds a commandline argument
'-commandkeys', that enables the commands in "interactive" mode (i.e. no
'-ign_eof' and no '-quiet'). It is *not* enabled by default.

Option 1 is what I'd use, but only because I really have no idea what the
initial use-case was for these "commands" (especially since "Q" is
identical to EOF).


Justification: The 'R' for 'r'enegotiate in particular seems to be
nothing but a source of confusion and bugs to be worked-around. Googling
(unquoted:) "s_client renegotiate" yields nothing in the first 50 results
that isn't one of:

1) the s_client 'man' page
2) someone warning others to not start their s_client lines with 'R'
3) a patch to other software to use the -ign_eof flag to avoid this

The use of 'Q' and 'R' affects interactive sessions of SMTP, IMAP, and
POP3 (that I know of), which are prime candidates for testing via
s_client. (In SMTP, 'RCPT TO' is essential. In IMAP, 'Q' and 'R' are
perfectly fine starting chars for command identifiers. And POP3 has
'RETR'.)

Thanks for the consideration.

Best,
Ben
»|« RT 3.4.5 Copyright 1996-2005 Best Practical Solutions, LLC.
Time to display: 0.45493