Skip Menu |
 
Ticket metadata
The Basics
Id: 3279
Status: resolved
Priority: 0/
Queue: OpenSSL-Bugs

Custom Fields
Milestone: (no value)
Subsystem: (no value)
Severity: (no value)
Broken in: (no value)

People
Owner: Nobody in particular
Requestors: Gerik Rhoden
Cc:
AdminCc:

More about the requestors

Gerik Rhoden

Comments about this user: No comment entered about this user
Groups this user belongs to
  • Unprivileged
  • Everyone

New reminder:
Subject:
Owner:
Due:

Dates
Created: Fri Mar 07 18:01:36 2014
Starts: Not set
Started: Fri Mar 07 20:09:29 2014
Last Contact: Mon Jun 02 15:27:41 2014
Due: Not set
Closed: Mon Jun 02 15:27:41 2014
Updated: Mon Jun 02 15:27:41 2014 by Stephen Henson



Subject: debug-VC-WIN32 build broken in 1.0.1f
Date: Fri, 7 Mar 2014 11:08:03 +0000
To: "rt@openssl.org" <rt@openssl.org>
From: Gerik Rhoden <Gerik.Rhoden@intercede.com>
Download (untitled) / with headers
text/plain 1.6k
The debug-VC-WIN32 build has been broken between 1.0.1e and 1.0.1f using Visual Studios 2010 and 2012, due to usage of the /WX compile option.

openssl-1.0.1f/ssl/s23_clnt.c line 283

The problem was fixed in 1.0.2, but not in master:

From c97ec5631bb08a2171a125008d2f0d2a75687aaa Mon Sep 17 00:00:00 2001
From: "Dr. Stephen Henson" <steve@openssl.org>
Date: Sun, 1 Dec 2013 23:30:21 +0000
Subject: [PATCH] Fix warning.

---
ssl/s23_clnt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ssl/s23_clnt.c b/ssl/s23_clnt.c
index 3aae220..710d4f2 100644
--- a/ssl/s23_clnt.c
+++ b/ssl/s23_clnt.c
@@ -282,7 +282,7 @@ int ssl_fill_hello_random(SSL *s, int server, unsigned char *result, int len)
send_time = (s->mode & SSL_MODE_SEND_CLIENTHELLO_TIME) != 0;
if (send_time)
{
- unsigned long Time = time(NULL);
+ unsigned long Time = (unsigned long)time(NULL);
unsigned char *p = result;
l2n(Time, p);
return RAND_pseudo_bytes(p, len-4);
--
1.7.9.5

Gerik Rhoden
Senior Software Developer
Intercede
ID anywhere™ • mobile ǀ smart cards ǀ devices

Office: +44 (0)1455 558 111
www.intercede.com<http://www.intercede.com/> | @intercedemyid<https://twitter.com/intercedemyid>

Legal Disclaimer<http://www.intercede.com/?q=node/266>
On Fri Mar 07 18:01:36 2014, Gerik.Rhoden@intercede.com wrote:
Show quoted text
> The debug-VC-WIN32 build has been broken between 1.0.1e and 1.0.1f
> using Visual Studios 2010 and 2012, due to usage of the /WX compile
> option.
>

This should be fixed in the 1.0.1 stable branch and any recent snapshot. It will appear in 1.0.1g

Steve.
-- 
Dr Stephen N. Henson. OpenSSL project core developer.
Commercial tech support now available see: http://www.openssl.org
Fixed now, ticket resolved.

Steve.
-- 
Dr Stephen N. Henson. OpenSSL project core developer.
Commercial tech support now available see: http://www.openssl.org